Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mods: Remove uses of Autohook from modkeyvalues.cpp #818

Merged
merged 2 commits into from
Oct 30, 2024
Merged

mods: Remove uses of Autohook from modkeyvalues.cpp #818

merged 2 commits into from
Oct 30, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • Check the file for anything that would depend on AUTOHOOK_INIT to run

Testing:

  • None needed? This was just an unused AUTOHOOK_INIT? I guess just make sure the game launches still?

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 8, 2024
F1F7Y
F1F7Y approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@F1F7Y F1F7Y added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Sep 8, 2024
@GeckoEidechse GeckoEidechse changed the title Remove uses of Autohook from modkeyvalues.cpp mods: Remove uses of Autohook from modkeyvalues.cpp Oct 30, 2024
GeckoEidechse
GeckoEidechse approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in quick testing. Game still launches.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 30, 2024
@GeckoEidechse GeckoEidechse merged commit 10041ca into R2Northstar:main Oct 30, 2024
4 checks passed
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Nov 12, 2024
@ASpoonPlaysGames @wolf109909
mods: Remove uses of Autohook from modkeyvalues.cpp (R2Northstar#818)
6d719af 
Remove unused AUTOHOOK_INIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1F7Y F1F7Y F1F7Y approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y