Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gamemode] Headhunter (again) #498

Closed
wants to merge 38 commits into from
Closed

[Gamemode] Headhunter (again) #498

wants to merge 38 commits into from

Conversation

Coopyy
Copy link
Contributor

@Coopyy Coopyy commented Sep 1, 2022

"hey didnt he already make a pr for this"
well its been 8 months and theres still no thunderstore so im back (karma told me to)
#187

Headhunter

kinda like the faster paced sibling to Fastball
works on all maps (yes live fire maps, just dont get thrown)

You're thrown into the map by BT and pilots are eliminated when killed
pilots drop a battery on death, you can pick up multiple batteries
for each battery you return, you revive a dead teammate
if time runs out team with more players alive wins

(also fixed crash with dying with more than 4 batteries :] )

medias:
great videos and gameplay from iniquity:
https://youtu.be/Hqrz7y-RNbg
https://youtu.be/JweMsade_Ag
heres a Macro video
https://www.youtube.com/watch?v=Mf_-0vAM1LM

uh

uh2

@GeckoEidechse GeckoEidechse added the gamemode Issues related to gamemodes, custom or vanilla label Sep 1, 2022
@Coopyy Coopyy changed the title New Gamemode: Headhunter [again] [Gamemode] Headhunter (again) Sep 1, 2022
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still a lot of formatting issues

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github truly has one of the shittiest review systems

Copy link
Member

@BobTheBob9 BobTheBob9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs testing and localization before merge, but looks pretty good

Coopyy and others added 19 commits November 24, 2022 11:27
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Coopyy and others added 6 commits November 24, 2022 11:37
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
@Coopyy
Copy link
Contributor Author

Coopyy commented Nov 24, 2022

why must there be 25 separate suggestions i must commit

that is 15 minutes of my life vanished

@GeckoEidechse
Copy link
Member

why must there be 25 separate suggestions i must commit

that is 15 minutes of my life vanished

FYI, if you go to the Files changed tab, you can queue up accepting suggested changes and commit them all at once. GitHub just doesn't make this obvious at all ^^

@Coopyy
Copy link
Contributor Author

Coopyy commented Sep 4, 2023

what is it whining about

Coopyy and others added 4 commits September 4, 2023 15:05
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
RAAAAAAAAAAAAAAAAAAAAAGH
@Coopyy
Copy link
Contributor Author

Coopyy commented Sep 4, 2023

ebic

@GeckoEidechse
Copy link
Member

With progress on auto-mod-download, I think this is one of the gamemodes that should get verified via VerifiedMods repo so that players can auto-download it on server join :D

@GeckoEidechse
Copy link
Member

And just to be clear mods get verified way faster than PRs get merged as verification only checks for malicious code, we don't really check for correctness etc ^^

@GeckoEidechse
Copy link
Member

HotPotato which was another gamemode stuch in PR hell got added as a verified mod now (R2Northstar/VerifiedMods#24)

Looking forward to seeing a PR to get Headhunter added as well 👀

@GeckoEidechse
Copy link
Member

bump

GeckoEidechse added a commit to GeckoEidechse/Headhunter that referenced this pull request Aug 14, 2024
Takes the files from R2Northstar/NorthstarMods#498 and adjusts them for a standalone mod

Co-authored-by: Coopyy <26663693+Coopyy@users.noreply.github.com>
@GeckoEidechse
Copy link
Member

@Coopyy I reuploaded the PR as a standalone mod now via https://github.com/GeckoEidechse/Headhunter/ and made a verification request via R2Northstar/VerifiedMods#42

If you'd rather have the mod be published entirely under your own name, please LMK and get in touch and I will retract my verification request and Thunderstore upload and you can publish it under your own name and request verification from there.

Either way, I'd say it's best to close this PR now as the gamemode makes more sense to be released standalone and downloaded automatically on join using mod-auto-download (MAD) as soon as R2Northstar/Northstar#674 is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gamemode Issues related to gamemodes, custom or vanilla
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants