Skip to content

Commit

Permalink
feat: Remove compatibility tool check (#607)
Browse files Browse the repository at this point in the history
Remove compatibility tool check as all major proton versions can run Northstar out of the box or with minor configurations:

- Proton 8 needs a DLLOVERRIDE
- GE-Proton works like a charm with a special Northstar case
- NorthstarProton always worked
  • Loading branch information
Jan200101 authored Oct 10, 2023
1 parent 394b2f7 commit 1815aa8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
4 changes: 0 additions & 4 deletions src-tauri/src/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,3 @@ pub const NORTHSTAR_DLL: &str = "Northstar.dll";

/// Profile that Northstar defaults to and ships with
pub const NORTHSTAR_DEFAULT_PROFILE: &str = "R2Northstar";

/// List of valid compatibility tools that Northstar can be launched with
pub const VALID_NORTHSTAR_PROTON_BUILDS: [&str; 3] =
["NorthstarProton-8.1-1", "GE-Proton8-13", "GE-Proton8-11"];
12 changes: 2 additions & 10 deletions src-tauri/src/northstar/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pub mod profile;

use crate::util::check_ea_app_or_origin_running;
use crate::{
constants::{CORE_MODS, TITANFALL2_STEAM_ID, VALID_NORTHSTAR_PROTON_BUILDS},
constants::{CORE_MODS, TITANFALL2_STEAM_ID},
get_host_os, GameInstall, InstallType,
};
use anyhow::anyhow;
Expand Down Expand Up @@ -144,15 +144,7 @@ pub fn launch_northstar_steam(
if get_host_os() != "windows" {
let titanfall2_steamid: u32 = TITANFALL2_STEAM_ID.parse().unwrap();
match steamdir.compat_tool(&titanfall2_steamid) {
Some(compat) => {
if !VALID_NORTHSTAR_PROTON_BUILDS
.contains(&compat.clone().name.unwrap().as_str())
{
return Err(
"Titanfall2 was not configured to use a valid version of NorthstarProton or GE-Proton".to_string(),
);
}
}
Some(_) => {}
None => {
return Err(
"Titanfall2 was not configured to use a compatibility tool".to_string()
Expand Down

0 comments on commit 1815aa8

Please sign in to comment.