Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add button to disable ModSettings mod #393

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

GeckoEidechse
Copy link
Member

In preparation for Northstar releasing merged Mod Settings mod.

image

In preparation for Northstar releasing merged Mod Settings mod
@GeckoEidechse GeckoEidechse added the enhancement New feature or request label Jun 23, 2023
@GeckoEidechse
Copy link
Member Author

@EladNLG Hi :)

@EladNLG
Copy link

EladNLG commented Jun 23, 2023

hello yes what do youk want

@catornot
Copy link
Contributor

you should probably also add a button to disable all mods that depend on ModSettings.

@GeckoEidechse
Copy link
Member Author

you should probably also add a button to disable all mods that depend on ModSettings.

Do we need one? Cause AFAIK the merged code mirrors ModSettings functions so one can simply drop ModSettings mod, no?

@catornot
Copy link
Contributor

you should probably also add a button to disable all mods that depend on ModSettings.

Do we need one? Cause AFAIK the merged code mirrors ModSettings functions so one can simply drop ModSettings mod, no?

I though it was different ¯\_(ツ)_/¯

@ASpoonPlaysGames
Copy link
Contributor

Do we need one? Cause AFAIK the merged code mirrors ModSettings functions so one can simply drop ModSettings mod, no?

Not necessarily, there are two cases where they will break:

If a mod relies on pre 2.0 modsettings (should be very rare now, and not a lot we can do about it)

If a mod uses dependency constants. this will break the mod in some way, depends how it is made. Some mods will prompt the user to download modsettings, which is going to be confusing since it wont work

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on Windows.

@GeckoEidechse GeckoEidechse merged commit b8b715f into main Jul 2, 2023
14 checks passed
@GeckoEidechse GeckoEidechse deleted the feat/repair-window-modsettings-disable branch July 16, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants