Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace game_scanner usage with winreg #394

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

Jan200101
Copy link
Contributor

closes #101

Not compiled on Windows (I don't have a setup for that, so someone else needs to do it).

Error message was updated to reflect this works on Origin and the EA App (should the text be changed to only mention the EA App, since Origin is considered defunct?), though the function name was not updated.

Moved winapi and winreg dependencies into the windows only dependencies, since other systems don't make use of them.

@GeckoEidechse
Copy link
Member

Currently also don't have a working Windows setup rn to test. Will do in a day or two hopefully.

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on Windows 10.
FlightCore found the path of my Steam install through registry successfully.

@GeckoEidechse
Copy link
Member

FlightCore found the path of my Steam install through registry successfully.

Given that this affects only EA App. We should still test on a setup that only has EA App and no Steam. In particular, detecting Steam install is done via library.vdf and not registry.

@Jan200101
Copy link
Contributor Author

I'll setup a clean VM and test a fresh install from both Origin and the EA App.

@Alystrasz
Copy link
Contributor

My bad!

@Jan200101
Copy link
Contributor Author

Fresh Install of Titanfall 2 from the EA App

image

I'll test Origin later today with Fuck_off_EA_App

@GeckoEidechse
Copy link
Member

Fresh Install of Titanfall 2 from the EA App

You're awesome, thanks <3

I'll test Origin later today with Fuck_off_EA_App

Wouldn't mind but honestly not necessary. They should behave the same and tbh I'm not gonna consider it any more. Compared to EA App Origin is a minority and those few that still use it can probably also figure out how to manually set a path should it somehow fail ^^

@GeckoEidechse GeckoEidechse merged commit b4728ee into R2NorthstarTools:main Jul 2, 2023
7 checks passed
@Jan200101
Copy link
Contributor Author

On Origin (with an incomplete install. Why doesn't the EA App have this feature? its really cool!)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace game-scanner library with simple call to Windows registry
3 participants