-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace game_scanner usage with winreg #394
Conversation
Currently also don't have a working Windows setup rn to test. Will do in a day or two hopefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working on Windows 10.
FlightCore found the path of my Steam install through registry successfully.
Given that this affects only EA App. We should still test on a setup that only has EA App and no Steam. In particular, detecting Steam install is done via |
I'll setup a clean VM and test a fresh install from both Origin and the EA App. |
My bad! |
Fresh Install of Titanfall 2 from the EA App I'll test Origin later today with Fuck_off_EA_App |
You're awesome, thanks <3
Wouldn't mind but honestly not necessary. They should behave the same and tbh I'm not gonna consider it any more. Compared to EA App Origin is a minority and those few that still use it can probably also figure out how to manually set a path should it somehow fail ^^ |
closes #101
Not compiled on Windows (I don't have a setup for that, so someone else needs to do it).
Error message was updated to reflect this works on Origin and the EA App (should the text be changed to only mention the EA App, since Origin is considered defunct?), though the function name was not updated.
Moved winapi and winreg dependencies into the windows only dependencies, since other systems don't make use of them.