Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warning for Snap installations #399

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: Add warning for Snap installations #399

merged 1 commit into from
Jul 18, 2023

Conversation

Jan200101
Copy link
Contributor

Needs testing

closes #398

src-tauri/Cargo.toml Outdated Show resolved Hide resolved
@Jan200101
Copy link
Contributor Author

Rebasing to resolve conflicts and clean up the history.
No review existed and the prior state was broken so I force pushed.
Future changes will be additional commits.

@GeckoEidechse GeckoEidechse changed the title Add warning for Snap installations feat: Add warning for Snap installations Jul 17, 2023
@GeckoEidechse
Copy link
Member

As for testing, I guess we'll just do it in production ¯\_(ツ)_/¯

@GeckoEidechse GeckoEidechse merged commit 9e6806b into R2NorthstarTools:main Jul 18, 2023
@Jan200101
Copy link
Contributor Author

I've tested it by manually injecting values on an Ubuntu LTS Desktop install.

steamlocate-rs does not currently support snap, WilliamVenner/steamlocate-rs#30

@GeckoEidechse
Copy link
Member

Welp, guess we just future proofed then a bit, haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect and warn about Snap installs
2 participants