feat: Delete old version when updating mod #401
Conversation
Deletes all Northstar mods based on Thunderstore mod string before installing new version. This way we can clean up old files from mods before installing new version
|
Right now there's no way to tell in this part of the code whether we are dealing with an update or an install. Maybe we should refactor code to pass an argument that tells whether we are installing or updating? |
|
(Haven't actually tested yet) |
|
Tested with https://northstar.thunderstore.io/package/Creamy_jpg/Customisable_Reticles_Framework/ which seems to work. Although I need to check what happens if the update to install is incorrectly formatted. Pretty sure it just nukes the mod then but fails to install the new one... |
Yup just tested with https://northstar.thunderstore.io/package/ScureX/ModCreator/ by manually putting it into mod folders, setting it up to look like older version and then trying to "update" it. The result is that the old version gets remove but the new one fails to install which shouldn't happen IMO. If the update fails, it should just keep the old version installed. Not sure what the best approach is here to achieve that... Any help would be appreciated <3 |
|
With R2Northstar/NorthstarLauncher#503 this PR in its current state won't be necessary anymore |
|
Closed by #415 |
Deletes all Northstar mods based on Thunderstore mod string before installing new version. This way we can clean up old files from mods before installing new version.
Note that the deletion is purposefully only done right before mod is extracted from install. This means it has already been downloaded. This is done to avoid the case where due to a slow internet connection an install fails but the old version of the mod is already removed due to the new logic.
Closes #408