Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frs & asyeos cmake errors #1072

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

YanzhaoW
Copy link
Contributor

Adapt FRS repository to CMake targets.


Checklist:

@YanzhaoW
Copy link
Contributor Author

Hi @jose-luis-rs

I submit a PR in frs repo and it's required to pass the CI of this PR.

@YanzhaoW YanzhaoW changed the title Fix frs cmake errors Fix frs & asyeos cmake errors Jun 17, 2024
@YanzhaoW
Copy link
Contributor Author

For the next time when both R3BRoot and subprojects needed to be changed, I think it's better to merge the PRs in the subprojects first and make sure the CIs are passed here before its merging.

@jose-luis-rs
Copy link
Contributor

Thanks @YanzhaoW
Now the code compiles with all the subprojects under FairRoot19.0.0, but it still fails with previous versions.

@YanzhaoW
Copy link
Contributor Author

Ok, I will fix that in this PR.

@YanzhaoW
Copy link
Contributor Author

YanzhaoW commented Jun 18, 2024

Hi, @jose-luis-rs

All tests in our CI (which uses FairRoot 18.8) passed. Are there any errors from your side?

@jose-luis-rs jose-luis-rs merged commit 4be5449 into R3BRootGroup:dev Jun 19, 2024
5 checks passed
@jose-luis-rs
Copy link
Contributor

Many thanks @YanzhaoW

@YanzhaoW YanzhaoW deleted the edwin_frs_cmake branch November 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants