Divergent Overlaps Implementations

[James-Oswald]

We have divergent overlaps implementations causing issues.
in elipse.ts

    public overlaps(otherShape: Rectangle | Ellipse): boolean {
        if (otherShape instanceof Rectangle) {
            for (let i = 0; i < 4; i++) {
                if (this.containsPoint(otherShape.getCorners()[i])) {
                    return true;
                }
            }

            return false;
        } else {
            //check if the rectangular bounding boxes of the ellipse overlap
            if (
                this.boundingBox.overlaps((otherShape as Ellipse).boundingBox) ||
                //this.boundingBox.containsShape((otherShape as Ellipse).boundingBox) ||
                (otherShape as Ellipse).boundingBox.containsShape(this.boundingBox)
            ) {
                //return true;
                //if there is an overlap, check if points along the ellipse curve overlap
                //this can be done by checking if points along the curve of this ellipse
                //are within the other ellipse
                const points: Point[] = this.getEllipsePoints();
                for (let i = 0; i < points.length; i++) {
                    if (otherShape.containsPoint(points[i])) {
                        return true;
                    }
                }
            }
            return false;
        }
    }

and in rectangle.ts

    public overlaps(otherShape: Rectangle | Ellipse): boolean {
        if (otherShape instanceof Rectangle) {
            return this.edgesOverlap(otherShape);
        } else if (otherShape instanceof Ellipse) {
            for (let i = 0; i < 4; i++) {
                if (otherShape.containsPoint(this.getCorners()[i])) {
                    return true;
                }
            }
            return false;
        } else {
            throw Error("Invalid Shape passed to overlaps, must be a Rectangle | Ellipse");
        }
    }

elipse.overlaps(rectangle) and rectangle.overlaps(ellipse) should ALWAYS return the same thing
but clearly, they don't due to the fact we have completely deferent implementations.
You should move ALL of this logic to a single helper function (probably in a new file, AEGUtils or something) overlaps(s1 : Rectangle | Ellipse, s2 : Rectangle | Ellipse) that both methods call.