Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inserting something around something else #106

Closed
James-Oswald opened this issue Oct 9, 2023 · 4 comments · Fixed by #115 or #118
Closed

Fix inserting something around something else #106

James-Oswald opened this issue Oct 9, 2023 · 4 comments · Fixed by #115 or #118
Assignees
@AnushaTiwari5 @RyanR712
Labels
Bug Something isn't working. Rightmost number in semantic versioning required This feature is required to be implemented by the current implementation team
Milestone
Sprint 10/16

Comments

@James-Oswald
Copy link
Member

canInsert currently does not allow you to surround an already placed object, This forces the tree to be built from the top down. Fix this to allow for surrounding one or multiple objects and inserting them into the tree correctly.
image
image
@James-Oswald James-Oswald added the Bug Something isn't working. Rightmost number in semantic versioning label Oct 9, 2023
@James-Oswald James-Oswald added this to the Sprint 10/16 milestone Oct 9, 2023
@James-Oswald James-Oswald added the required This feature is required to be implemented by the current implementation team label Oct 9, 2023
@RyanR712 RyanR712 self-assigned this Oct 10, 2023
@James-Oswald
Copy link
Member Author

This may actually be caused by issues in overlaps/intersections functioning as overlaps rather than intersects.
https://discord.com/channels/1143025340189523968/1143025340646707341/1161153332073730131

@James-Oswald
Copy link
Member Author

May be fixed by #108 currently open under sub-issue #109

@AnushaTiwari5 AnushaTiwari5 linked a pull request Oct 12, 2023 that will close this issue
no executions on my watch #115
Merged
@James-Oswald
Copy link
Member Author

image We're back!

@James-Oswald James-Oswald reopened this Oct 12, 2023
@AnushaTiwari5
Copy link
Collaborator

Insert around fixed, new bug on drawing ellipse within existing ellipse

@AnushaTiwari5 AnushaTiwari5 linked a pull request Oct 13, 2023 that will close this issue
fixing rectangle overlap logic #118
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnushaTiwari5 AnushaTiwari5

@RyanR712 RyanR712

Labels
Bug Something isn't working. Rightmost number in semantic versioning required This feature is required to be implemented by the current implementation team
Projects
None yet
Milestone
Sprint 10/16
3 participants
@James-Oswald @AnushaTiwari5 @RyanR712