Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite With Universal Event Listeners #64

Closed
James-Oswald opened this issue Sep 27, 2023 · 2 comments
Closed

Rewrite With Universal Event Listeners #64

James-Oswald opened this issue Sep 27, 2023 · 2 comments
Assignees
@DawnTheWitch
Labels
Enhancement New feature optional This feature is not required to be implemented by the current implementation team
Milestone
Sprint 10/16

Comments

@James-Oswald
Copy link
Member

Rewrite the frontend canvas listeners to use universal event listeners (A single listener function for each event that passes control to separate functions based on state (such as mode)) to stop the need for complex event listener logic that is causing bugs such as #62 and #63.
@James-Oswald James-Oswald added Enhancement New feature optional This feature is not required to be implemented by the current implementation team labels Sep 27, 2023
@James-Oswald James-Oswald added this to the Milestone 5: Demo 2 milestone Sep 27, 2023
DawnTheWitch added a commit that referenced this issue Sep 30, 2023
@DawnTheWitch
Fix for issue #21 and 90% sure Issue #62
0ed8cf7 
One minor additional issue, if you start making an ellipse run it into the wall to kill it the switch to atom mode to place an atom the ellipse will pop up a moment before disappearing again.
The ghost of the ellipse will likely be fixed with issue issue #64, Universal Event Listeners
Which is coming... I promise
@DawnTheWitch DawnTheWitch mentioned this issue Sep 30, 2023
Merged
@DawnTheWitch DawnTheWitch linked a pull request Oct 9, 2023 that will close this issue
Homunculus Event Handlers with a splash of #48 #93
Merged
DawnTheWitch added a commit that referenced this issue Oct 9, 2023
@DawnTheWitch
Merge pull request #94 from RAIRLab/master
3acd931 
Merge Master into Issue #64
@James-Oswald James-Oswald removed a link to a pull request Oct 9, 2023
Homunculus Event Handlers with a splash of #48 #93
Merged
@James-Oswald
Copy link
Member Author

Partially handled by #93

@DawnTheWitch DawnTheWitch linked a pull request Oct 9, 2023 that will close this issue
Actual Universe Event Handlers* #104
Closed
@James-Oswald
Copy link
Member Author

Closed by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawnTheWitch DawnTheWitch

Labels
Enhancement New feature optional This feature is not required to be implemented by the current implementation team
Projects
None yet
Milestone
Sprint 10/16
Development

Successfully merging a pull request may close this issue.

Actual Universe Event Handlers* RAIRLab/Peirce-My-Heart
3 participants
@James-Oswald @AnushaTiwari5 @DawnTheWitch