Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

105 divergent overlaps implementations #108

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

AnushaTiwari5
Copy link
Collaborator

No description provided.

… draw cuts around existing nodes. Private members for Cut and Atom, with setters and getters
@AnushaTiwari5 AnushaTiwari5 added this to the Sprint 10/16 milestone Oct 10, 2023
@AnushaTiwari5 AnushaTiwari5 self-assigned this Oct 10, 2023
@AnushaTiwari5 AnushaTiwari5 linked an issue Oct 10, 2023 that may be closed by this pull request
src/AEG/AEGUtils.ts Show resolved Hide resolved
* Method that checks if any edges of this rectangle overlap with the other rectangle.
* @param otherRect The other rectangle to be checked.
* @returns True, if edges overlap. Else, false.
* @todo This algo can and should be simplified to be less than 10 lines of code. -James-Oswald
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address this @ todo note some point.

src/AEG/AEGUtils.ts Show resolved Hide resolved
src/AEG/AtomNode.ts Show resolved Hide resolved
src/AEG/AEGTree.ts Show resolved Hide resolved
src/AEG/AEGTree.ts Show resolved Hide resolved
@James-Oswald James-Oswald merged commit c9e9e49 into master Oct 10, 2023
@James-Oswald James-Oswald deleted the 105-divergent-overlaps-implementations branch October 10, 2023 06:17
@James-Oswald
Copy link
Member

Closed #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divergent Overlaps Implementations
2 participants