Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo and Redo Shortcuts! #360

Merged
merged 20 commits into from
Apr 13, 2024
Merged

Undo and Redo Shortcuts! #360

merged 20 commits into from
Apr 13, 2024

Conversation

RyanR712
Copy link
Collaborator

No description provided.

@RyanR712 RyanR712 added Enhancement New feature No API-Break Will not break test results or backwards compatibility. Middle number in semantic versioning labels Jan 27, 2024
@RyanR712 RyanR712 self-assigned this Jan 27, 2024
@RyanR712 RyanR712 linked an issue Jan 27, 2024 that may be closed by this pull request
Ctrl+Z Ctrl+Y for Proof and Draw modes #270
Closed
@RyanR712
Copy link
Collaborator Author

Functionality is correct from my testing. Organization is probably not optimal. Particular attention would be appreciated for testing a bunch of different combinations of proof and draw tools. Marking ready for review

@RyanR712 RyanR712 requested a review from James-Oswald March 18, 2024 18:54
@RyanR712 RyanR712 marked this pull request as ready for review March 18, 2024 18:54
James-Oswald
James-Oswald reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@James-Oswald James-Oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some large concerns regarding a potential API break that will prevent files from being saved and loaded.

src/DrawHistory/DrawModeMove.ts Outdated Show resolved Hide resolved
src/ProofHistory/ProofModeMove.ts Outdated Show resolved Hide resolved
src/ProofHistory/ProofHistory.ts Outdated Show resolved Hide resolved
src/AEG-IO.ts Show resolved Hide resolved
@James-Oswald James-Oswald added API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning and removed No API-Break Will not break test results or backwards compatibility. Middle number in semantic versioning labels Mar 22, 2024
@RyanR712 RyanR712 requested a review from James-Oswald April 4, 2024 16:48
@James-Oswald James-Oswald removed the API-Break Will break test results or backwards compatibility. Leftmost number in semantic versioning label Apr 13, 2024
@James-Oswald James-Oswald merged commit 8a40d13 into master Apr 13, 2024
6 checks passed
@James-Oswald James-Oswald deleted the 270-undo-redo-buttons branch April 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Oswald James-Oswald James-Oswald approved these changes

Assignees

@RyanR712 RyanR712

Labels
Enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl+Z Ctrl+Y for Proof and Draw modes
2 participants
@RyanR712 @James-Oswald