Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

388 firefox cannot save or load files fix #390

Merged
merged 8 commits into from
May 6, 2024
Merged

388 firefox cannot save or load files fix #390

merged 8 commits into from
May 6, 2024

Conversation

James-Oswald
Copy link
Member

  • Save now falls back to cross-browser FileSaver.js library
  • Refactored to move saveMode and loadMode and related utils out of index and into AEG-IO where they belong.
  • Filenames for draw mode files are now their string representation.

@James-Oswald James-Oswald requested a review from RyanR712 May 5, 2024 16:51
@James-Oswald James-Oswald linked an issue May 5, 2024 that may be closed by this pull request
Firefox Cannot Save or Load Files #388
Closed
@James-Oswald James-Oswald self-assigned this May 5, 2024
@James-Oswald James-Oswald added No API-Break Will not break test results or backwards compatibility. Middle number in semantic versioning Bug Something isn't working. Rightmost number in semantic versioning labels May 5, 2024
RyanR712
RyanR712 requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@RyanR712 RyanR712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests perfectly. Just worried about a duplicate entry in the package files.

package.json Show resolved Hide resolved
package-lock.json Show resolved Hide resolved
James-Oswald
James-Oswald commented May 6, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@RyanR712 RyanR712 self-requested a review May 6, 2024 15:56
@James-Oswald James-Oswald merged commit 8d21575 into master May 6, 2024
6 checks passed
@James-Oswald James-Oswald deleted the 388-firefox-cannot-save-files branch May 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanR712 RyanR712 RyanR712 approved these changes

Assignees

@James-Oswald James-Oswald

Labels
Bug Something isn't working. Rightmost number in semantic versioning No API-Break Will not break test results or backwards compatibility. Middle number in semantic versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox Cannot Save or Load Files
2 participants
@James-Oswald @RyanR712