Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homunculus Event Handlers with a splash of #48 #93

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Homunculus Event Handlers with a splash of #48 #93

merged 8 commits into from
Oct 9, 2023

Conversation

DawnTheWitch
Copy link
Collaborator

Very heavy draft, has some temporary bits to draw the bounding boxes.
The actual event handlers were a bit weird because I wanted to be able to read whenever any mouse event happened but that apparently isn't allowed so I had to clump them all up and delete them all at the same time.
Also the actual handlers are incredibly hard to read because lint gets upset when I try to space them.

@DawnTheWitch DawnTheWitch added this to the Sprint 10/9 milestone Oct 9, 2023
@DawnTheWitch DawnTheWitch self-assigned this Oct 9, 2023
@DawnTheWitch DawnTheWitch linked an issue Oct 9, 2023 that may be closed by this pull request
Rewrite With Universal Event Listeners #64
Closed
@DawnTheWitch DawnTheWitch marked this pull request as draft October 9, 2023 00:35
@DawnTheWitch
Minor fix on mouseup
2576bca 
I foolishly only changed the bounding box setting in mousemove so mouseup made the atom spawn with a messed up bounding box
@DawnTheWitch
Merge pull request #94 from RAIRLab/master
3acd931 
Merge Master into Issue #64
@DawnTheWitch DawnTheWitch marked this pull request as ready for review October 9, 2023 02:19
@DawnTheWitch
Fix displaybox colors and extra line on ellipse
dba5e3e
@DawnTheWitch
Woops console.log included
88686ea
@DawnTheWitch
Another 1 line change I'm sorry
882e19a 
Haha tiny brain
@DawnTheWitch
Merge pull request #96 from RAIRLab/master
2b9dfef 
Merging into UEH
@DawnTheWitch
Misc changes
9db6301 
Changed error color back to red
added comments
Set the minimum radius to 15
I think I might have forgotten what else sorry boss
@James-Oswald James-Oswald changed the title Universal Event Handlers with a splash of #48 Homunculus Event Handlers with a splash of #48 Oct 9, 2023
@James-Oswald James-Oswald removed a link to an issue Oct 9, 2023
Rewrite With Universal Event Listeners #64
Closed
@James-Oswald James-Oswald linked an issue Oct 9, 2023 that may be closed by this pull request
World's Smallest Ellipse, World's Longest Ellipse, World's Tallest Ellipse. #48
Closed
James-Oswald
James-Oswald approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@James-Oswald James-Oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UEI's should have a single event handler function for each event type that is never added or removed. From this event handler you then switch based on mode and call functions that take the events from the mode's file.

@James-Oswald James-Oswald merged commit 0bea196 into master Oct 9, 2023
4 checks passed
@James-Oswald James-Oswald deleted the 64-rewrite-with-universal-event-listeners branch October 9, 2023 04:29
@James-Oswald James-Oswald mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Oswald James-Oswald James-Oswald approved these changes

Assignees

@DawnTheWitch DawnTheWitch

Labels
None yet
Projects
None yet
Milestone
Sprint 10/9
Development

Successfully merging this pull request may close these issues.

World's Smallest Ellipse, World's Longest Ellipse, World's Tallest Ellipse.
2 participants
@DawnTheWitch @James-Oswald