rectangle overlap when no corners within bug fix #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnushaTiwari5
added
the
Bug
James-Oswald
approved these changes
Oct 9, 2023
Comment on lines
+105
to
+141
| /** | ||
| * Checks if any of the horizontal edges of the other rectangle lie within the horizontal | ||
| * boundaries of this rectangle | ||
| * @param otherRect The other rectangle | ||
| * @returns True, if the other edges lie within this boundary. Else, false | ||
| */ | ||
| private checkHorizontalEdgeOverlap(otherRect: Rectangle): boolean { | ||
| const thisCorners = this.getCorners(); | ||
| const otherCorners = otherRect.getCorners(); | ||
|
|
||
| if (thisCorners[0].y <= otherCorners[0].y && thisCorners[2].y >= otherCorners[0].y) { | ||
| return true; | ||
| } else if (thisCorners[0].y <= otherCorners[2].y && thisCorners[2].y >= otherCorners[2].y) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Checks if any of the vertical edges of the other rectangle lie within the vertical | ||
| * boundaries of this rectangle | ||
| * @param otherRect The other rectangle | ||
| * @returns True, if the other edges lie within this boundary. Else, false | ||
| */ | ||
| private checkVerticalEdgeOverlap(otherRect: Rectangle): boolean { | ||
| const thisCorners = this.getCorners(); | ||
| const otherCorners = otherRect.getCorners(); | ||
|
|
||
| if (thisCorners[0].x <= otherCorners[0].x && thisCorners[1].x >= otherCorners[0].x) { | ||
| return true; | ||
| } else if (thisCorners[0].x <= otherCorners[1].x && thisCorners[1].x >= otherCorners[1].x) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This code is repetitive, we can abstract this into a single function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and tested, I believe this should detect collision even when the corners of the bounding boxes are not within the other.