-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand permissions system #1267
Expand permissions system #1267
Conversation
8572de7
to
92645ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit of doc to add, and explain a bit more how this works from the user perspective in the PR description. Do I choose to register permission ? Is is automatic ? Can you do it on build or only in editor ?
c944adf
to
e264a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a detailed description of the PR
0143b68
to
613eede
Compare
@stilnat added docs and description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix build error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected, good job
Summary
Expands and cleans up the permissions systems to facilitate changes, adds the missing change permission and save permissions functionality.
Creates a permission settings file to define if a server/host should get the owner permission whenever they join the game.
Adds the functionality to change a user's permission, and the functionality to save the permissions back to the permissions file, this can be used if the permissions are changed runtime, ex. when an admin gives a non admin the admin permission.
PR checklist
Testing
This can be tested by running the game as the host, with the AddServerOwnerPermissionToServerHost setting ticked under "ProjectSettings/SS3D/Server/PermissionSettings", this should change the host permission to "Server Owner" whenever the server is started. There should be logs for this.
Networking checklist
Changes
Many changes are related to import settings, the permissions system was moved to a separate assembly as it is very independent and that makes things more modular.