Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue201 compare vulnerabilities #218

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

PhillipsOwen
Copy link
Collaborator

this addresses issue #201

the solution was to

  • fork the orginal repo,
  • remove the hard-coded package version declarations
  • and fix as many warnings as i could.

you can run "npm uninstall leaflet-side-by-side" to remove the no longer needed package.

Please merge and remove the branch if the solution is acceptable. once i see that happen i will build/deploy immediately due to the nature of this issue.

Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing

Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lstillwe lstillwe merged commit 5085b06 into main Sep 11, 2024
1 check passed
@lstillwe lstillwe deleted the issue201-compare-vulnerabilities branch September 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants