Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue214 - Update sidebar layer tray to toggle raster layers like the control panel. #222

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

lstillwe
Copy link
Contributor

This update causes the sidebar layer tray to toggle raster layer visibility more like radio buttons.
This is how the raster layers are toggled in the control panel.

Please merge and remove branch on approval.

…ers like radion buttons similar to how the control panel works
@lstillwe lstillwe requested review from mbwatson and PhillipsOwen and removed request for mbwatson September 11, 2024 21:41
Copy link
Collaborator

@PhillipsOwen PhillipsOwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am seeing that layers on a model run are sorted (in reverse order) following a control panel advisory decrement.

@PhillipsOwen
Copy link
Collaborator

are the up/down buttons on each layer card redundant? they no longer seem to have a purpose in light of the new radio button like functionality.

@lstillwe
Copy link
Contributor Author

i am seeing that layers on a model run are sorted (in reverse order) following a control panel advisory decrement.

i am seeing that layers on a model run are sorted (in reverse order) following a control panel advisory decrement.

I assume that was originally done so the last layer to be rendered was the one at the top of the defaultModelLayers array.

@lstillwe
Copy link
Contributor Author

are the up/down buttons on each layer card redundant? they no longer seem to have a purpose in light of the new radio button like functionality.

are the up/down buttons on each layer card redundant? they no longer seem to have a purpose in light of the new radio button like functionality.

Probably. I consider this fix a temporary step - till issue #215 is done.

@lstillwe lstillwe merged commit b1dfaa9 into main Sep 12, 2024
1 check passed
@lstillwe lstillwe deleted the issue214 branch September 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants