-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 199 - package updates #224
Conversation
@@ -331,8 +331,8 @@ export const ControlPanel = () => { | |||
sx={{ | |||
p: 0, | |||
position: 'absolute', | |||
bottom: 'calc(4 * var(--joy-spacing))', | |||
right: 'calc(4 * var(--joy-spacing))', | |||
bottom: '20px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the css variable names are prefixed with "mui" on this branch, so this variable would be --mui-spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think special calcs are needed here. so i hard coded them into the right hand corners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think using that css var matters too much, though.
👍 found 0 vulnerabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works!
addresses issue #199
this updates all react packages for the UI to the latest versions.
i found two inconsistencies when doing this:
you will have to perform a "npm update" to upgrade your local packages.