Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 199 - package updates #224

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Issue 199 - package updates #224

merged 4 commits into from
Sep 12, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

addresses issue #199

this updates all react packages for the UI to the latest versions.

i found two inconsistencies when doing this:

  • eslint was reporting errors in the recently added side/side compare code. i disabled the lint check.
  • the positioning of the legend and control panel had to be hard-coded. as apparently "calc" went wonky.

you will have to perform a "npm update" to upgrade your local packages.

@@ -331,8 +331,8 @@ export const ControlPanel = () => {
sx={{
p: 0,
position: 'absolute',
bottom: 'calc(4 * var(--joy-spacing))',
right: 'calc(4 * var(--joy-spacing))',
bottom: '20px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the css variable names are prefixed with "mui" on this branch, so this variable would be --mui-spacing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think special calcs are needed here. so i hard coded them into the right hand corners.

Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think using that css var matters too much, though.

👍 found 0 vulnerabilities

@PhillipsOwen PhillipsOwen changed the title Issue199 - package updates Issue 199 - package updates Sep 12, 2024
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works!

@lstillwe lstillwe merged commit 2e6b36c into main Sep 12, 2024
1 check passed
@lstillwe lstillwe deleted the issue199-package-updates branch September 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants