Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observation chart - A good place #31

Merged
merged 57 commits into from
May 8, 2024
Merged

Observation chart - A good place #31

merged 57 commits into from
May 8, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented May 8, 2024 •
edited
Loading

this has the chart looking good. but still needs some things:

  • the on/off selection of a line.
  • adopt the "dark mode".
  • use CSS directives rather than hard-coding inline.
  • cascade open dialogs rather than stacking them.
  • clicking on a dialog in the background should bring it to the foreground.
  • support resizing the dialog

PhillipsOwen and others added 30 commits May 3, 2024 16:30
@PhillipsOwen
generalizing its usage better by passing the data key and state data/…
4058b8c 
…setter references
@PhillipsOwen
now calling an object to render the graph and the generalized params …
6d5dfeb 
…for the floating dialog
@PhillipsOwen
adding an id to the feature props to remove it from the selected list…
8ad109e 
… in BaseFloatingDialog
@PhillipsOwen
adjusting the params sent to BaseFloatingDialog
e1daa6d
@PhillipsOwen
generalizing the id used for removing data list items from state
f2a5ce9
@PhillipsOwen
new component to render the observation data as a chart
a317555
@PhillipsOwen
checkpointing current state of branch
d96611e
@PhillipsOwen
removing TODO as it is done
6760c13
@PhillipsOwen
checkpointing current state of code
294a3b3
@PhillipsOwen
tidying up
89fa591
@PhillipsOwen
tidying up
e561cb9
@PhillipsOwen
definition for the remove all observations sidebar
ae04250
@PhillipsOwen
adding a component that will be rendered on the sidebar to remove all…
109e730 
… observation selection dialogs
@PhillipsOwen
adding a component to the sibebar
8a572f5
@PhillipsOwen
tidying up, adding comments
fb03178
@lstillwe
updates for addition and removal of target icon for observations sele…
02b2ccf 
…cted
@PhillipsOwen
moving files around, working on line chart
88583f5
@PhillipsOwen
Merge branch 'observation-chart' of https://github.com/RENCI/APSViz-U…
9e82a77 
…I-V3 into use-reducer

# Conflicts:
#	src/app.js
#	src/components/dialog/base-floating-dialog.js
#	src/components/dialog/observation-dialog.js
@PhillipsOwen
changing imports to reference a new location for dialog components
d784a2d
@PhillipsOwen
fixing linting issue
2b68fd1
@PhillipsOwen
fixing linting issue
f1c3c5b
@PhillipsOwen
adding new map bullseye references
ce61067
@PhillipsOwen
correcting merge mishap
2ed09ec
@PhillipsOwen
adjusting sizing
d8bc7be
@PhillipsOwen
adjusting sizing
1b195b2
@PhillipsOwen
trying to resync with main
bd53023
@PhillipsOwen
Merge remote-tracking branch 'origin/observation-chart' into observat…
4da51cc 
…ion-chart
@PhillipsOwen
generalizing its usage better by passing the data key and state data/…
c2a03ec 
…setter references
@PhillipsOwen
now calling an object to render the graph and the generalized params …
efc3f2e 
…for the floating dialog
@PhillipsOwen
adding an id to the feature props to remove it from the selected list…
54c50ce 
… in BaseFloatingDialog
PhillipsOwen and others added 26 commits May 7, 2024 14:39
@PhillipsOwen
generalizing the id used for removing data list items from state
45010dd
@PhillipsOwen
new component to render the observation data as a chart
78457f4
@PhillipsOwen
checkpointing current state of branch
7bf94d0
@PhillipsOwen
removing TODO as it is done
c9f2f4b
@PhillipsOwen
checkpointing current state of code
387e3d4
@lstillwe @PhillipsOwen
updates for addition and removal of target icon for observations sele…
7379c41 
…cted
@PhillipsOwen
tidying up
f777c41
@PhillipsOwen
tidying up
d2d6e15
@PhillipsOwen
definition for the remove all observations sidebar
ca1016d
@PhillipsOwen
adding a component that will be rendered on the sidebar to remove all…
1183561 
… observation selection dialogs
@PhillipsOwen
adding a component to the sibebar
5243175
@PhillipsOwen
tidying up, adding comments
7157d31
@PhillipsOwen
moving files around, working on line chart
ca4524b
@PhillipsOwen
changing imports to reference a new location for dialog components
c0f7282
@PhillipsOwen
fixing linting issue
3b4c8b3
@PhillipsOwen
fixing linting issue
f27466f
@PhillipsOwen
adding new map bullseye references
043c3b0
@PhillipsOwen
correcting merge mishap
17bebb0
@PhillipsOwen
trying to resync with main
94f193d
@PhillipsOwen
Merge remote-tracking branch 'origin/observation-chart' into observat…
b12b534 
…ion-chart

# Conflicts:
#	src/components/dialog/base-floating-dialog.js
@PhillipsOwen
Merge remote-tracking branch 'origin/main' into observation-chart
fce2723
@PhillipsOwen
tidying up
f04c47c
@PhillipsOwen
commenting out console log
57a741f
@PhillipsOwen
correcting the prop name for the map reference
f79a860
@PhillipsOwen
correcting the look of the graph
859f81e
@PhillipsOwen
correcting the look of the graph
ecfcd31
@PhillipsOwen PhillipsOwen requested a review from lstillwe May 8, 2024 16:14
@lstillwe lstillwe merged commit 05a6356 into main May 8, 2024
1 check passed
@lstillwe lstillwe deleted the observation-chart branch May 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstillwe lstillwe lstillwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhillipsOwen @lstillwe