Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings to backup & restore wallet #53

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tmalahie
Copy link
Contributor

@tmalahie tmalahie commented Dec 7, 2024

This PR adds the necessary bindings to perform the backup mechanism (rgblib_backup and rgblib_restore_backup)

Copy link
Collaborator

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the requested changes.
After addressing those please squash the code from this PR into a single signed commit, named c-ffi bindings: add backup, restore_backup and backup_info. Finally rebase the commit on the updated master. Thanks

bindings/c-ffi/src/utils.rs Outdated Show resolved Hide resolved
bindings/c-ffi/src/utils.rs Outdated Show resolved Hide resolved
bindings/c-ffi/src/utils.rs Outdated Show resolved Hide resolved
bindings/c-ffi/src/utils.rs Outdated Show resolved Hide resolved
@tmalahie tmalahie force-pushed the backup-wallet-bindings branch 2 times, most recently from 74380a5 to 903d8cc Compare December 11, 2024 19:56
@tmalahie tmalahie force-pushed the backup-wallet-bindings branch from 903d8cc to d2d1790 Compare December 11, 2024 19:56
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (f04ff8d) to head (d2d1790).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files          61       61           
  Lines       19966    19966           
=======================================
  Hits        19227    19227           
  Misses        739      739           
Flag Coverage Δ
rust 96.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

@zoedberg zoedberg merged commit 203e41e into RGB-Tools:master Dec 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants