tests retrying an aborted transfer #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Details about the bugs have been reported in RGB-WG/rgb-std#287 |
zoedberg
changed the title
zoedberg
force-pushed
the
debug_abort_transfer
branch
from
3f9a86a to
cfed8e4
Compare
|
Force-pushed to update rgb-std and bp-wallet to their latest master tip. Tests fail as before. |
zoedberg
force-pushed
the
debug_abort_transfer
branch
from
0c859f5 to
59dec46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master RGB-WG/rgb-core#23 +/- ##
==========================================
+ Coverage 36.49% 36.53% +0.04%
==========================================
Files 279 279
Lines 42806 42806
==========================================
+ Hits 15620 15641 +21
+ Misses 27186 27165 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
same_transfer_twicetest in 3 tests:rbf_transfer: this is the same test as before, it has just been renamed with a more precise namesame_transfer_twice_no_update_witnesses: this test shows 2 bugssame_transfer_twice_update_witnesses: this test shows 1 bugP.S. Since the bugs appear only on branches ready for beta 9 this PR contains also a WIP commit that updates the tests in order to use the updated branches. I suggest looking only at the last commit to understand the reported bugs