Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HMS-2256): enhance wizard first page interface #293

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

amirfefer
Copy link
Member

This PR enhances the Account and customization step in the wizard

  • All select inputs have maxHeight for fixing select content override
  • Content is aligned to the wizard layout, minimizes the need for a scroll bar
  • Alert warning for the instance types is removed and replaced by inner validation and helper text
  • Instance type select switched location with Templates select
  • Template select's dropdown opens in the upper direction

Before:

Screen.Recording.2023-08-03.at.13.24.34.mov

After:

Screen.Recording.2023-08-03.at.13.09.05.mov

@lzap
Copy link
Member

lzap commented Aug 7, 2023

Please note this is a temporary solution. Long term, we would like to break this page into multiple screens or something like that.

WFM @ezr-ondrej ?

Can we merge today so we can hit prod tomorrow?

@ezr-ondrej
Copy link
Member

/retest

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🧡
I do not fully understand the options, but looks quite sane 👍

I'm happy to merge if this is not breaking the pipeline 👍

@ezr-ondrej
Copy link
Member

Merging, the failing test is unstable, so lets hope this is not a culprit of the failure :)
Thanks @amirfefer ! 👍

@ezr-ondrej ezr-ondrej merged commit d3918a8 into RHEnVision:main Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants