Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Attributes reading + Move LCD regions to Lcd #212

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

AlessioC31
Copy link
Collaborator

@AlessioC31 AlessioC31 commented Sep 16, 2023

This PR adds reading into specific structs the object attributes memory region (basically sprite data).

Plus, I also moved all the LCD related regions to Lcd.

@AlessioC31 AlessioC31 changed the title Object Attributes reading Object Attributes reading + Move LCD regions to Lcd Sep 16, 2023
Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

emu/src/render/ppu.rs Outdated Show resolved Hide resolved
emu/src/render/ppu.rs Outdated Show resolved Hide resolved
@guerinoni guerinoni added this pull request to the merge queue Sep 21, 2023
Merged via the queue into RIP-Comm:main with commit 420fe3c Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants