Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise validity period #6

Closed
wants to merge 3 commits into from
Closed

Precise validity period #6

wants to merge 3 commits into from

Conversation

lolepezy
Copy link
Contributor

This is to align all validity periods for all objects that are signed

@lolepezy lolepezy requested review from ties and bjpbakker November 16, 2023 16:11
@lolepezy lolepezy marked this pull request as draft November 16, 2023 16:12
@lolepezy
Copy link
Contributor Author

lolepezy commented Nov 16, 2023

I seriously don't understand why TA.calculateNextUpdateTime is doing what it's doing.
I have a feeling it was copy-pasted from some previous version of the TA software.

I believe updatePeriod is how often we do re-signing. But it is only used in calculateNextUpdateTime and doesn't do anything else. So the while loop is a fancy way of saying "validity period must be the largest of getMinimumValidityPeriod and getUpdatePeriod".

We can

  • remove both updatePeriod and minimumValidityPeriod and create a mftAndCrlValidityPeriod and set it to 3 months
  • rewrite TA.calculateNextUpdateTime so that it picks up the longest period
  • keep it as is and add an apologetic comment there and we don't know why

@lolepezy lolepezy marked this pull request as ready for review November 16, 2023 16:29
@lolepezy lolepezy closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant