Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing out the welcome mat #9

Merged
merged 13 commits into from
Nov 18, 2023
Merged

Conversation

ActuallyTaylor
Copy link
Contributor

Removed unnecessary code that caused the heap to overflow and the board to crash when too many objects were initialized. Also fixed the crash that would happen when the HUDL received a crashed status. Most of these fixes were solved by removing 1024 byte EVT logo...

Signed-off-by: ActuallyTaylor taylor.lineman@gmail.com

Signed-off-by: ActuallyTaylor <zachary.lineman@gmail.com>
Signed-off-by: ActuallyTaylor <zachary.lineman@gmail.com>
@ActuallyTaylor ActuallyTaylor requested a review from a team October 17, 2023 01:03
Copy link
Contributor

@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but formatting is a bit strange

src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
src/HUDL/HUDL.cpp Show resolved Hide resolved
src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
targets/HUDL/main.cpp Outdated Show resolved Hide resolved
targets/HUDL/main.cpp Outdated Show resolved Hide resolved
targets/HUDL/main.cpp Outdated Show resolved Hide resolved
@mjmagee991 mjmagee991 requested a review from a team October 23, 2023 00:27
ActuallyTaylor and others added 3 commits October 25, 2023 22:32
Co-authored-by: Matthew Magee <mjmagee991@gmail.com>
Co-authored-by: Matthew Magee <mjmagee991@gmail.com>
Signed-off-by: ActuallyTaylor <taylor.lineman@gmail.com>
@mjmagee991 mjmagee991 self-requested a review October 28, 2023 23:33
Copy link
Contributor

@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to go

src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
targets/HUDL/main.cpp Show resolved Hide resolved
targets/HUDL/main.cpp Outdated Show resolved Hide resolved
ActuallyTaylor and others added 3 commits October 30, 2023 19:50
Signed-off-by: ActuallyTaylor <taylor.lineman@gmail.com>
Signed-off-by: ActuallyTaylor <taylor.lineman@gmail.com>
Copy link
Contributor

@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three minor details, and then you're good to merge

src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
src/HUDL/HUDL.cpp Outdated Show resolved Hide resolved
targets/HUDL/main.cpp Outdated Show resolved Hide resolved
@mjmagee991 mjmagee991 requested a review from a team November 3, 2023 23:46
ActuallyTaylor and others added 3 commits November 4, 2023 10:11
Co-authored-by: Matthew Magee <mjmagee991@gmail.com>
Co-authored-by: Matthew Magee <mjmagee991@gmail.com>
Signed-off-by: ActuallyTaylor <taylor.lineman@gmail.com>
Copy link
Contributor

@mjh9585 mjh9585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, otherwise good.

targets/HUDL/main.cpp Outdated Show resolved Hide resolved
Co-authored-by: mjh9585 <69865851+mjh9585@users.noreply.github.com>
@ActuallyTaylor ActuallyTaylor merged commit 6fd9835 into main Nov 18, 2023
1 check passed
@ActuallyTaylor ActuallyTaylor deleted the feature/actuallytaylor/speedy branch November 27, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants