Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerization of workflow #97

Merged
merged 22 commits into from
May 6, 2024
Merged

Containerization of workflow #97

merged 22 commits into from
May 6, 2024

Conversation

florianzwagemaker
Copy link
Contributor

fix: split rules to separate dependencies
fix: split combined job to separate script-based job for better dependency management
ci: add supplementary scripts for container build process
…conda or containers)

fix: properly set the readline tabcompleter
…e snakemake_run_con object to properly access it from within workflows
…nakemake_run_conf object

feat: add singularity arguments to snakemake config

fix: pass the snakemak configuration settings in a dictionary to the snakemake workflow itself

style: formatting with isort &  black

feat: handle the downloading of containers in the viroconstrictor wrapper
…nakemake_run_conf object

feat: add singularity arguments to snakemake config for main workflow

fix: pass the snakemake configuration settings in a dictionary to the main snakemake workflow itself

feat: handle the downloading of containers necessary for main workflow in the viroconstrictor wrapper
Refactor the GitHub Actions workflows to update the triggers for container publishing. Change the trigger for the "build_and_test.yml" workflow to only run on pull requests to the main branch. Additionally, add a new workflow "publish_containers.yaml" to handle the publishing of containers. This workflow will be triggered on pushes to the dev branch.

Related recent commits:
- ci: change upstream registry
- ci: temporarily add listing of directory contents for debugging purposes
- ci: add step in container build/test workflow to download already existing containers
The `download_containers` function in the `containers.py` module has been refactored to include better error handling and logging. Previously, if a container failed to download, the function would return a non-zero status code without providing any specific error message. Now, when a container fails to download, the function logs an error message indicating the name of the container that failed. This change improves the clarity of error reporting and makes it easier to troubleshoot container download issues.

Related recent commits:
- refactor: add verbose option to `download_containers` function
- ci: temporarily add listing of directory contents for debugging purposes
- ci: add step in container build/test workflow to download already existing containers
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

@florianzwagemaker florianzwagemaker merged commit 7679e8e into dev May 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant