Update multi-image3 to catch failures in multi-image generation #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update multi-image testing to catch if all images were actually created. Also explicitly checks for target features xnack+ and xnack-.
nicebert
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
jplehr
requested changes
Oct 1, 2024
| @@ -15,4 +15,4 @@ CC = $(OMP_BIN) $(VERBOSE) | |||
| include ../Makefile.rules | |||
| run: $(TESTNAME) | |||
There was a problem hiding this comment.
The run rule is not used by the check_smoke script, so, this extra part will not be tested.
Please use the RUNCMD to provide more complex rules than ./$(TESTNAME). The RUNCMD will be used by the check rule when set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update multi-image testing to catch if all images were actually created. Also explicitly checks for target features xnack+ and xnack-.