Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multi-image3 to catch failures in multi-image generation #1016

Open
wants to merge 1 commit into
base: aomp-dev
Choose a base branch
from
Open

Update multi-image3 to catch failures in multi-image generation #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/smoke/multi-image3/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ TESTSRC_MAIN = multi-image.c
TESTSRC_AUX =
TESTSRC_ALL = $(TESTSRC_MAIN) $(TESTSRC_AUX)

OMP_FLAGS = -fopenmp --offload-arch=$(AOMP_GPU)$(AOMP_TARGET_FEATURES) --offload-arch=gfx803$(AOMP_TARGET_FEATURES) --offload-arch=gfx1031$(AOMP_TARGET_FEATURES)
OMP_FLAGS = -fopenmp --offload-arch=$(AOMP_GPU)$(AOMP_TARGET_FEATURES),gfx90a:xnack+,gfx90a:xnack-
CLANG = clang
OMP_BIN = $(AOMP)/bin/$(CLANG)
CC = $(OMP_BIN) $(VERBOSE)
Expand All @@ -15,4 +15,4 @@ CC = $(OMP_BIN) $(VERBOSE)
include ../Makefile.rules
run: $(TESTNAME)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run rule is not used by the check_smoke script, so, this extra part will not be tested.

Please use the RUNCMD to provide more complex rules than ./$(TESTNAME). The RUNCMD will be used by the check rule when set.

./$(TESTNAME)
strings $(TESTNAME) |grep -i gfx
strings $(TESTNAME) | grep $(AOMP_GPU)$(AOMP_TARGET_FEATURES) && strings $(TESTNAME) | grep gfx90a:xnack+ && strings $(TESTNAME) | grep gfx90a:xnack-