Add not supported transpose check

ROCm · Oct 4, 2024 · f6ba1de · f6ba1de
1 parent f5028bb
commit f6ba1de
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/clients/benchmarks/README.md b/clients/benchmarks/README.md
@@ -36,8 +36,8 @@ cd hipBLASLt; cd build/release
 --compute_input_typeB <value>     Options: f32_r, f16_r, bf16_r, f8_r, bf8_r, The default value indicates that the argument has no effect. (Default value is: INVALID)
 --scale_type <value>       Precision of scalar. Options: f16_r,bf16_r
 --initialization <value>   Initialize matrix data.Options: rand_int, trig_float, hpl(floating), special, zero  (Default value is: hpl)
---transA <value>           N = no transpose, T = transpose, C = conjugate transpose                            (Default value is: N)
---transB <value>           N = no transpose, T = transpose, C = conjugate transpose                            (Default value is: N)
+--transA <value>           N = no transpose, T = transpose                                                     (Default value is: N)
+--transB <value>           N = no transpose, T = transpose                                                     (Default value is: N)
 --batch_count <value>      Number of matrices. Only applicable to batched and strided_batched routines         (Default value is: 1)
 --HMM                      Parameter requesting the use of HipManagedMemory
 --verify |-v               Validate GPU results with CPU?

diff --git a/clients/benchmarks/client.cpp b/clients/benchmarks/client.cpp
@@ -419,11 +419,11 @@ try
 
         ("transA",
          value<char>(&arg.transA)->default_value('N'),
-         "N = no transpose, T = transpose, C = conjugate transpose")
+         "N = no transpose, T = transpose")
 
         ("transB",
          value<char>(&arg.transB)->default_value('N'),
-         "N = no transpose, T = transpose, C = conjugate transpose")
+         "N = no transpose, T = transpose")
 
         ("batch_count",
          value<int32_t>(&arg.batch_count)->default_value(1),

diff --git a/docs/clients.rst b/docs/clients.rst
@@ -86,8 +86,8 @@ For more information, see command:
    --compute_type <value>     Precision of computation. Options: s,f32_r,x,xf32_r,f64_r,i32_r                     (Default value is: f32_r)
    --scale_type <value>       Precision of scalar. Options: f16_r,bf16_r
    --initialization <value>   Initialize matrix data.Options: rand_int, trig_float, hpl(floating), special, zero  (Default value is: hpl)
-   --transA <value>           N = no transpose, T = transpose, C = conjugate transpose                            (Default value is: N)
-   --transB <value>           N = no transpose, T = transpose, C = conjugate transpose                            (Default value is: N)
+   --transA <value>           N = no transpose, T = transpose                                                     (Default value is: N)
+   --transB <value>           N = no transpose, T = transpose                                                     (Default value is: N)
    --batch_count <value>      Number of matrices. Only applicable to batched and strided_batched routines         (Default value is: 1)
    --HMM                      Parameter requesting the use of HipManagedMemory
    --verify |-v               Validate GPU results with CPU?

diff --git a/library/src/amd_detail/rocblaslt/src/include/rocblaslt_mat_utils.hpp b/library/src/amd_detail/rocblaslt/src/include/rocblaslt_mat_utils.hpp
@@ -353,6 +353,8 @@ inline rocblaslt_status rocblaslt_matmul_valid_args(const rocblaslt_matmul_desc
                  && matD->type == HIP_R_8I))
            && compute_type == rocblaslt_compute_i32)
             status = rocblaslt_status_not_implemented;
+        if(matmul_descr->op_A == HIPBLAS_OP_C || matmul_descr->op_B == HIPBLAS_OP_C)
+            status = rocblaslt_status_not_implemented;
     }
     const void* alphaVecPtr = matmul_descr->pointermode ? alpha : nullptr;
     if(status == rocblaslt_status_continue)

diff --git a/library/src/include/auxiliary.hpp b/library/src/include/auxiliary.hpp
@@ -214,7 +214,7 @@ HIPBLASLT_EXPORT
 constexpr hipDataType string_to_hip_datatype_assert(const std::string& value)
 {
     auto datatype = string_to_hip_datatype(value);
-    if(static_cast<int>(datatype) == 0)
+    if(datatype == HIPBLASLT_DATATYPE_INVALID)
     {
         std::cout << "The supported types are f32_r, f64_r, f16_r, bf16_r, f8_r, bf8_r, i8_r, i32_r." << std::endl;
         exit(1);