Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aquavanjaram942_20&80CU TT libs #1146

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove aquavanjaram942_20&80CU TT libs #1146

wants to merge 1 commit into from
+0 −4,801,758

Conversation

babakpst
Copy link
Contributor

No description provided.

@babakpst babakpst added the noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. label Sep 20, 2024
nakajee
nakajee approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@nakajee nakajee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@StaceyLai
Copy link
Contributor

If your commit involves changes to a YAML file, please take note.

Due to PR-1117 (#1117) adding ActivationType: hipblaslt_all, all YAML files now need to include the ActivationType field (for hipblaslt logic YAML, use ActivationType: hipblaslt_all (not all); for tensile test YAML, you can use either all or hipblaslt_all).

Correspondingly, in the Logic YAML filename, the _A that originally represented ActivationType: all should also be changed to _HA. These changes have been implemented in PR-1117.

@nakajee
Copy link
Contributor

nakajee commented Oct 3, 2024

This PR is just removing some logic yaml. No further change needed related to 1117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakajee nakajee nakajee approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss aazz44ss is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
noCI Disable testing on supported CI systems: math libraries CI has this feature enabled..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babakpst @StaceyLai @nakajee