-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HostLibraryTests back to hipBLASLt #1147
base: develop
Are you sure you want to change the base?
Conversation
Modularize GSU code so it is more contained, reduces branch points in KernelWriter code. Fix a temp register allocation bug. Fix alignment of some registers rather than rely on a specific order.
ROCm#3) * Support for predicate arithmetic intensity added on top of streamK branch in Alex's repo
* Analytical grid size prediction model for Stream-K
Porting code gen changes for stream-k
…current vgpr allocations
…t into addHostLibraryTestInit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these yaml files are taken from /library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/aquavanjaram/gfx942/GridBased/
and modified to specify Euclidean instead of GridBased
If your commit involves changes to a YAML file, please take note. Due to PR-1117 (#1117) adding Correspondingly, in the Logic YAML filename, the |
The first set of changes to add some tests back. I'll need thorough review by team members experienced with these test behaviours.
Note I could use some guidance from the PR below breaking LLVM/LibraryPerformanceTests with the following error code
tensilelite/build3/data/Kernels.yaml:1185820:5: error: missing required key 'workGroupMappingXCCGroup'
mahmoodw@298ab70#diff-9bb4bcad898531e5b352e879b6ba3af8101259c53c1382d5466f5410c06592ceR3947
specifically,
https://github.com/mahmoodw/hipBLASLt/blob/3669450e5c7024758d59b58e581504e88c7c1508/tensilelite/Tensile/Source/lib/include/Tensile/Serialization/ContractionSolution.hpp#L118
When trying to regenerate the library after these changes (using TensileCreateLibrary)
I get the error below
File "/home/wmahmood/initblasLt2/tensilelite/Tensile/TensileCreateLibrary.py", line 1475, in TensileCreateLibrary
assert len(sanityCheck0) == 0, "Unexpected code object files: {}".format(sanityCheck0)
AssertionError: Unexpected code object files: {'/home/wmahmood/initblasLt2/tensilelite/HostLibraryTests/library/TensileLibrary_gfx942.co'}