enable DirectToVgprA/B step 2 #1204
Open
+1,597
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nakajee
commented
Oct 4, 2024
•
nakajee
commented
- enable more data types (f8,f64)
- enable DirectToVgprB
- enable DTV + pack
- enable DTV + LocalSplitU
- enable DTV + MatrixInstB
- enable DTV + StreamK
- enable more data types (f8,f64) - enable DirectToVgprB - enable DTV + pack - enable DTV + LocalSplitU - enable DTV + MatrixInstB
nakajee
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
nakajee
commented
Oct 4, 2024
| @@ -3432,7 +3444,8 @@ def subCheckLdsBlockSizePerPad(tc, idx): | |||
| state["LdsOffsetB"] = state["LdsOffsetMetadata"] + state["LdsNumElementsAlignedMetadata"] | |||
|
|
|||
| offsetBlk = state["LdsOffsetB"] + ldsNumBytesAlignedB | |||
| offsetBlk = int(2**(math.ceil(math.log(offsetBlk, 2)))) | |||
| if offsetBlk > 0: | |||
There was a problem hiding this comment.
This is to prevent log 0 in DTVA+DTVB case.
| @@ -2135,6 +2146,7 @@ def assignDerivedParameters(state): | |||
|
|
|||
| if state["StreamK"] != 0: | |||
| state["GlobalSplitU"] = 0 # Cannot enable both Stream-K and GSU | |||
| state["GlobalSplitUAlgorithm"] = "MultipleBuffer" # Set default Algorithm | |||
There was a problem hiding this comment.
StreamK + GlobalSplitUAlgorithm casuses code generation error.
Force to set MultipleBuffer in StreamK case.
| @@ -1916,10 +1922,15 @@ def isDirectToVgprDoable(state, tc): | |||
| return False | |||
|
|
|||
| # does not work with UnrollLoopSwapGlobalReadOrder | |||
| if state["UnrollLoopSwapGlobalReadOrder"]>1: | |||
| if state["UnrollLoopSwapGlobalReadOrder"]: | |||
There was a problem hiding this comment.
This was a mistake in my previous commit.
Fixed the condition.
| @@ -162,7 +162,6 @@ class StateValues: | |||
| lrvwUnrollB: int = 0 | |||
| lrvwUnrollMetadata: int = 0 # For Sparse Metadat | |||
|
|
|||
| vgprValuDouble: bool = False | |||
There was a problem hiding this comment.
vgprValuDouble was not set to true anywhere.
This was originally added by me in Tensile for DirectToLds.
However, this was necessary due to some scheduling bug and this was already removed in Tensile.
I removed it this time (to avoid adding code for unnecessary feature).
|
I ran tensilelite tox and hipblaslt-test on local gfx942 node. |
|
Small update.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.