Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][hipCUB] Updated dependency branch parameters to CI jobs to be more consistent with rocThrust #442

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .jenkins/common.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@ def runCompileCommand(platform, project, jobName, boolean debug=false, boolean s
//Set CI node's gfx arch as target if PR, otherwise use default targets of the library
String amdgpuTargets = env.BRANCH_NAME.startsWith('PR-') ? '-DAMDGPU_TARGETS=\$gfx_arch' : ''

def getRocPRIM = auxiliary.getLibrary('rocPRIM', platform.jenkinsLabel, null, sameOrg)
def getDependenciesCommand = ""
if (project.installLibraryDependenciesFromCI)
{
project.libraryDependencies.each
{
libraryName ->
getDependenciesCommand += auxiliary.getLibrary(libraryName, platform.jenkinsLabel, 'develop', sameOrg)
}
}

def command = """#!/usr/bin/env bash
set -x
${getRocPRIM}
${getDependenciesCommand}
cd ${project.paths.project_build_prefix}
mkdir -p build/${buildTypeDir} && cd build/${buildTypeDir}
${auxiliary.gfxTargetParser()}
Expand Down
1 change: 1 addition & 0 deletions .jenkins/precheckin.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def runCI =

def prj = new rocProject('hipCUB', 'PreCheckin')
prj.timeout.compile = 400
prj.libraryDependencies = ["rocPRIM"]
// Define test architectures, optional rocm version argument is available
def nodes = new dockerNodes(nodeDetails, jobName, prj)

Expand Down
4 changes: 4 additions & 0 deletions .jenkins/staticlibrary.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ def runCI =

def prj = new rocProject('hipCUB', 'Static Library PreCheckin')

prj.libraryDependencies = ["rocPRIM"]
prj.timeout.compile = 500

def nodes = new dockerNodes(nodeDetails, jobName, prj)

def commonGroovy
Expand Down Expand Up @@ -55,6 +58,7 @@ ci: {
"rocm-docker":([ubuntu16:['gfx900'],centos7:['gfx906'],sles15sp1:['gfx908']])]
jobNameList = auxiliary.appendJobNameList(jobNameList)

auxiliary.registerDependencyBranchParameter(["rocPRIM"])
propertyList.each
{
jobName, property->
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Full documentation for hipCUB is available at [https://rocm.docs.amd.com/project
* Added `DeviceSelect::FlaggedIf` and its inplace overload.

### Changed
* Removed usage of `std::unary_function` and `std::binary_function` in `test_hipcub_device_adjacent_difference.cpp`
* Changed the subset of tests that are run for smoke tests such that the smoke test will complete with faster run-time and to never exceed 2GB of vram usage. Use `python rtest.py [--emulation|-e|--test|-t]=smoke` to run these tests.
* The `rtest.py` options have changed. `rtest.py` is now run with at least either `--test|-t` or `--emulation|-e`, but not both options.
* The NVIDIA backend now requires CUB, Thrust and libcu++ 2.5.0. If it is not found it will be downloaded from the NVIDIA CCCL repository.
Expand Down
1 change: 1 addition & 0 deletions hipcub/include/hipcub/backend/rocprim/hipcub.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@

// Device
#include "device/device_adjacent_difference.hpp"
#include "device/device_copy.hpp"
#include "device/device_histogram.hpp"
#include "device/device_memcpy.hpp"
#include "device/device_merge_sort.hpp"
Expand Down
4 changes: 2 additions & 2 deletions test/hipcub/test_hipcub_device_adjacent_difference.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ inline auto make_transform_iterator(InputIterator iterator, UnaryFunction transf
}

template<class T>
struct conversion_op : public std::unary_function<T, discard_write<T>>
struct conversion_op
{
HIPCUB_HOST_DEVICE
auto operator()(const T i) const
Expand All @@ -325,7 +325,7 @@ struct conversion_op : public std::unary_function<T, discard_write<T>>
};

template<class T>
struct flag_expected_op : public std::binary_function<T, T, discard_write<T>>
struct flag_expected_op
{
bool left;
T expected;
Expand Down
Loading