Add hipcub::TilePrefixCallbackOp and hipcub::ScanTileState #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beanavil
requested review from
a team,
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
spolifroni-amd
approved these changes
Dec 20, 2024
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
int8_t is not allowed as a result type of std::uniform_int_distribution. The standard says that the effect is undefined in this case but MSVC explicitly forbids it.
umfranzw
requested changes
Jan 9, 2025
hipcub/include/hipcub/backend/rocprim/agent/single_pass_scan_operators.hpp
Show resolved
Hide resolved
hipcub/include/hipcub/backend/rocprim/agent/single_pass_scan_operators.hpp
Show resolved
Hide resolved
umfranzw
approved these changes
Jan 10, 2025
| @@ -2,6 +2,17 @@ | |||
|
|
|||
| Full documentation for hipCUB is available at [https://rocm.docs.amd.com/projects/hipCUB/en/latest/](https://rocm.docs.amd.com/projects/hipCUB/en/latest/). | |||
|
|
|||
| ## (Unreleased) hipCUB-x.x.x for ROCm 6.x.x | |||
There was a problem hiding this comment.
We don't know what the next ROCm release/version will be, so I'm okay with leaving these placeholders in the changelog for now, but we'll need to fix this once we know what the next release version is.
stanleytsang-amd
approved these changes
Jan 10, 2025
|
CI tests passed except for BlockHistogram, which is most likely due to existing compiler bug. See ROCm/rocPRIM#672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these for CUB parity as requested.