Skip to content

Commit

Permalink
Merge pull request #301 from CongMa13/fix_to_6_3_1
Browse files Browse the repository at this point in the history
Fix to 6.3.1
  • Loading branch information
CongMa13 authored Dec 2, 2024
2 parents 68014b5 + 35a16b4 commit 0601c18
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 24 deletions.
31 changes: 17 additions & 14 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,31 @@

Full documentation for hipTensor is available at [rocm.docs.amd.com/projects/hiptensor](https://rocm.docs.amd.com/projects/hipTensor/en/latest/index.html).

## (Unreleased) hipTensor 1.4.0 for ROCm 6.3.0
## hipTensor 1.4.0 for ROCm 6.3.0

### Additions
### Added

* Added API support for tensor reduction of ranks 2, 3, 4, 5 and 6
* Added CPU reference for tensor reductions
* Added unit tests for tensor reductions
* Added documentation for tensor reductions
* Added support for tensor reduction, including APIs, CPU reference, unit tests, and documentation

### Changes
### Changed

* Updated target archs for ASAN builds
* ASAN library builds now use -mcmodel=large to accommodate larger lib size
* Updated permute backend to accommodate changes to element-wise ops implementation
* Updated validation acceptance criteria to match CK backend tests
* ASAN builds only support xnack+ targets.
* ASAN builds use `-mcmodel=large` to accommodate library sizes greater than 2GB.
* Updated the permute backend to accommodate changes to element-wise operations.
* Updated the actor-critic implementation.

### Fixes
### Optimized

* Fixed a bug in randomized tensor input data generation
* Various documentation formatting updates and fixes
* Split kernel instances to improve build times

### Resolved issues

* Fixed a bug in randomized tensor input data generation.
* Fixed the default strides calculation to be in column major order.
* Fixed a small memory leak by properly destroying HIP event objects in tests.
* Various documentation formatting updates and fixes.


Check failure on line 29 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / Documentation / Markdown

Multiple consecutive blank lines

CHANGELOG.md:29 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md012.md

Check failure on line 29 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / Documentation / Markdown

Multiple consecutive blank lines

CHANGELOG.md:29 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md012.md
## hipTensor 1.3.0 for ROCm 6.2.0

### Additions
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Optional:

## Build with CMake

For more detailed information, please refer to the [hipTensor installation guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/installation.html).
For more detailed information, please refer to the [hipTensor installation guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/install/installation.html).

### Project options

Expand Down Expand Up @@ -71,4 +71,4 @@ The latest official documentation for hipTensor is available at:

## Contributing to the hipTensor Library

Community collaboration is encouraged! If you are considering contributing, please follow the [hipTensor Contribution Guide](https://github.com/ROCm/hipTensor/CONTRIBUTING.md) to get started.
Community collaboration is encouraged! If you are considering contributing, please follow the [hipTensor Contribution Guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/contribution/contributors-guide.html) to get started.
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank1_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 13 ]
- [ 6 ]
Expand Down
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank2_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 13, 11]
- [ 6, 4]
Expand Down
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank3_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 11, 8, 5]
- [ 5, 6, 4]
Expand Down
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank4_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 13, 11, 8, 5]
- [ 3, 5, 6, 4]
Expand Down
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank5_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 13, 11, 8, 5, 4]
- [ 3, 5, 6, 4, 5]
Expand Down
2 changes: 1 addition & 1 deletion test/03_reduction/configs/rank6_test_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 2.3
- 2.3
Lengths:
- [ 7, 2, 8, 5, 4, 3]
- [ 3, 5, 6, 4, 5, 3]
Expand Down
4 changes: 2 additions & 2 deletions test/03_reduction/configs/reduction_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ Alphas:
- 2.3
Betas:
- 0.0
# - 1.0
# - 2.3
- 1.0
- 2.3
Lengths:
- [ 1, 1]
- [ 5, 2]
Expand Down

0 comments on commit 0601c18

Please sign in to comment.