Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README file #391

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

Include note about known issue with Perfetto v47.0 and above.

Include note about known issue with Perfetto v47.0 and above.
@dgaliffiAMD dgaliffiAMD requested a review from a team as a code owner September 24, 2024 20:44
@dgaliffiAMD
Copy link
Collaborator Author

Included a note about the known issue in the README file. I'd appreciate your feedback and proofread. Thank you.

README.md Outdated Show resolved Hide resolved
@dgaliffiAMD dgaliffiAMD requested review from ajanicijamd and removed request for maleksan85 September 24, 2024 21:55
ajanicijamd
ajanicijamd previously approved these changes Sep 25, 2024
you --> your
Copy link

@gsitaram gsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgaliffiAMD
Copy link
Collaborator Author

Thanks. I'll talk to the docs team about the best way to incorporate this note in the ROCm docs.

@dgaliffiAMD dgaliffiAMD merged commit 3285a53 into ROCm:main Sep 25, 2024
7 checks passed
@dgaliffiAMD dgaliffiAMD deleted the dgaliffi/readme-update-perfetto branch September 25, 2024 14:37
peterjunpark pushed a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
peterjunpark pushed a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
peterjunpark pushed a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
peterjunpark pushed a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants