Using rocm-cmake for SOVERSION (#228)

* Remove device generator versioning * Updating setting library SOVERSION with rocm-cmake
ROCm · Aug 2, 2019 · ed7760e · ed7760e
1 parent 5fe696b
commit ed7760e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/library/src/CMakeLists.txt b/library/src/CMakeLists.txt
@@ -105,7 +105,8 @@ target_include_directories( rocfft
           $<INSTALL_INTERFACE:include>
 )
 
-set_target_properties( rocfft PROPERTIES VERSION ${rocfft_VERSION} SOVERSION ${rocfft_SOVERSION} CXX_EXTENSIONS NO )
+rocm_set_soversion( rocfft ${rocfft_SOVERSION} )
+set_target_properties( rocfft PROPERTIES CXX_EXTENSIONS NO )
 set_target_properties( rocfft PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/staging" )
 set_target_properties( rocfft PROPERTIES DEBUG_POSTFIX "-d" )
 set_target_properties( rocfft PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON )

diff --git a/library/src/device/CMakeLists.txt b/library/src/device/CMakeLists.txt
@@ -117,7 +117,8 @@ target_include_directories( rocfft-device
           $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>
 )
 
-set_target_properties( rocfft-device PROPERTIES VERSION ${rocfft_VERSION} SOVERSION ${rocfft_SOVERSION} CXX_EXTENSIONS NO )
+rocm_set_soversion( rocfft-device ${rocfft_SOVERSION} )
+set_target_properties( rocfft-device PROPERTIES CXX_EXTENSIONS NO )
 set_target_properties( rocfft-device PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/staging" )
 set_target_properties( rocfft-device PROPERTIES DEBUG_POSTFIX "-d" )
 set_target_properties( rocfft-device PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON )

diff --git a/library/src/device/generator/CMakeLists.txt b/library/src/device/generator/CMakeLists.txt
@@ -5,7 +5,7 @@
 add_executable( rocfft-kernel-generator generator.main.cpp generator.file.cpp )
 target_compile_features( rocfft-kernel-generator PRIVATE cxx_static_assert cxx_nullptr cxx_auto_type )
 
-set_target_properties( rocfft-kernel-generator PROPERTIES VERSION ${rocfft_VERSION} CXX_EXTENSIONS NO )
+set_target_properties( rocfft-kernel-generator PROPERTIES CXX_EXTENSIONS NO )
 set_target_properties( rocfft-kernel-generator PROPERTIES DEBUG_POSTFIX "-d" )
 
 target_include_directories( rocfft-kernel-generator