Numerous hipblaslt related fixes #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemeliya
commented
Nov 27, 2024
pemeliya
commented
- fixing multi-threading/multi-GPU issue in gpublaslt matmul_op kernel
- added better cache gpublas_lt_matmul thunk
- added #define LEGACY_HIPBLAS_DIRECT to hipblaslt wrapper to fix potential problems with new hipblaslt versions
pemeliya
requested review from
i-chaochen,
jayfurmanek and
draganmladjenovic
i-chaochen
reviewed
Nov 28, 2024
| static std::deque< BlasLtMatmulPlanCache > meta(8); | ||
| absl::MutexLock lock(&m); | ||
| size_t dev_id = stream->parent()->device_ordinal(); | ||
| if (dev_id >= meta.size()) meta.resize(dev_id + 1); |
There was a problem hiding this comment.
If it's multi-nodes and each node at least has 8 gpus, I think we should meta.resize(dev_id + 8); ?
pemeliya
force-pushed
the
r2.17-rocm-enhanced-hipblaslt-fixes
branch
from
7cd6ea8 to
f229ec4
Compare
i-chaochen
approved these changes
Dec 2, 2024
|
We need this for 2.18 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.