-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev fix history unlabeled #318
Conversation
Expected behavior from this MR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this branch to make sure the skew and history(unlabeled) tabs were showing all unlabelled + unassigned data. To test this I:
- created a project with 25 data
- checked to make sure history and skew pages had correct counts
- labeled some data and checked again
- went to the annotate page as a different user to fake "assign data" and made sure counts were still correct
The skew and history pages had correct counts throughout, however I realized that the project details page was not showing the correct count for "Unlabeled and Unassigned". Proposed fix in this PR:
…unt_bug Fix count of unlabelled + unassigned on details page
The function to show unlabeled data was ignoring data in the "normal" queue instead of ignoring assigned data. The normal queue is the precursor to assignments, and is filled automatically by SMART when data is uploaded or the items in the existing queue are labeled.
The affect of this issue was that there was ~30 unlabeled data that wouldn't show up in the skew page or when someone selected "unlabeled data" in the history table, even if it wasn't assigned to anyone. The fix is two parts: first to stop excluding items in the normal queue when returning unlabeled data, and second when unlabeled data that is in the normal queue is labeled in the history or skew page we need to remove it from the queue so it doesn't ever get assigned.