Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev fix history unlabeled #318

Merged
merged 7 commits into from
May 8, 2024
Merged

Dev fix history unlabeled #318

merged 7 commits into from
May 8, 2024

Conversation

AstridKery
Copy link
Contributor

The function to show unlabeled data was ignoring data in the "normal" queue instead of ignoring assigned data. The normal queue is the precursor to assignments, and is filled automatically by SMART when data is uploaded or the items in the existing queue are labeled.

The affect of this issue was that there was ~30 unlabeled data that wouldn't show up in the skew page or when someone selected "unlabeled data" in the history table, even if it wasn't assigned to anyone. The fix is two parts: first to stop excluding items in the normal queue when returning unlabeled data, and second when unlabeled data that is in the normal queue is labeled in the history or skew page we need to remove it from the queue so it doesn't ever get assigned.

@AstridKery AstridKery self-assigned this Apr 29, 2024
@AstridKery
Copy link
Contributor Author

Expected behavior from this MR:

  • before the changes, the quantity of data returned when either checking off unlabeled data in the history table or going to the skew tab would be (total unlabeled and unassigned) - batch size
  • After the changes the amount of data returned should be equal to the count of (unlabeled + unassigned) on the details page
  • These changes are meant to update the queue when a queued item gets labeled in the history/skew page in the same way they do when someone labels it in the annotate page. The queue should also get refilled if it was empty from someone labeling everything in history, so that if they go to the annotate tab later it works properly.

Copy link
Contributor

@andykawabata andykawabata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch to make sure the skew and history(unlabeled) tabs were showing all unlabelled + unassigned data. To test this I:

  • created a project with 25 data
  • checked to make sure history and skew pages had correct counts
  • labeled some data and checked again
  • went to the annotate page as a different user to fake "assign data" and made sure counts were still correct

The skew and history pages had correct counts throughout, however I realized that the project details page was not showing the correct count for "Unlabeled and Unassigned". Proposed fix in this PR:

#319

andykawabata and others added 2 commits May 6, 2024 10:28
@AstridKery AstridKery merged commit b61b79c into dev May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants