Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Lb2pKg model #34

Merged
merged 18 commits into from
May 21, 2024
Merged

add Lb2pKg model #34

merged 18 commits into from
May 21, 2024

Conversation

IlyaSegal
Copy link
Collaborator

@IlyaSegal IlyaSegal commented May 14, 2024

Adds Lb2pKg with json and qmd files,

Closes #6

Copy link
Collaborator

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!
Seems that the model results in NaN values for now (?)

docs/_quarto.yml Outdated Show resolved Hide resolved
docs/julia/Lb2pKg.qmd Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyaSegal can you add *.html to .gitignore and remove this file?
Afaics, these files are generated in the source code folder (instead of _build/html) if you use quarto render (=pixi run doc).

docs/julia/Lb2pKg.qmd Outdated Show resolved Hide resolved
@mmikhasenko mmikhasenko changed the title Lb2p kg add Lb2pKg model May 14, 2024
@mmikhasenko
Copy link
Collaborator

I found the cause of the Inf: it was the normalization factors from #31

The BlattWeisskopf is currently defined as zˆL / pol(z) where z = R*p. If the radius is 0, the factor is 0. And 1/0 gives Inf resulting in NaN.

Now, the formfactors are replaced by the newly introduced MomentumPower factors.

@mmikhasenko
Copy link
Collaborator

The page should be built. The Dalitz looks reasonable, but the tests are not passed.

Copy link
Collaborator

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@mmikhasenko
Copy link
Collaborator

mmikhasenko commented May 17, 2024

Shall we aim to merge it today?

AFAIR, the status is that the validation tests fail.
A suggestion to proceeded is to create more validations.

Here is an input from the "true" model implementation, what we need to proceed here (open Lb2pKpi notebook, evaluate, report number here):

  • all lineshapes evaluated at sigma1, or sigma2, or sigma3
  • for a given kinematic point (say validation1), evaluate all chains separately: inpolarized_intensity(model[3:3], sigma_test1)

How does it sound @IlyaSegal

@IlyaSegal
Copy link
Collaborator Author

IlyaSegal commented May 17, 2024

After updating couplings, all validation points are yellow (difference in the third decimal digit).
Almost congratulations @mmikhasenko

@mmikhasenko
Copy link
Collaborator

That was it, congratulations!
image

Copy link
Collaborator

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, preview looks good now!

image
image
image

@IlyaSegal IlyaSegal merged commit 0c8f4b9 into main May 21, 2024
3 checks passed
@IlyaSegal IlyaSegal deleted the Lb2pKg branch May 21, 2024 18:04
@mmikhasenko mmikhasenko mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lb2pKgamma json file
3 participants