Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic function #59

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Generic function #59

merged 7 commits into from
Jun 4, 2024

Conversation

mmikhasenko
Copy link
Collaborator

Introduce generic_function, and replace rho and f2 in compass by it

@mmikhasenko
Copy link
Collaborator Author

To be merged after #55
Here, the name of variables needs to be renamed according to changes in #55

@mmikhasenko mmikhasenko self-assigned this Jun 1, 2024
@mmikhasenko mmikhasenko requested a review from redeboer June 1, 2024 22:43
@mmikhasenko
Copy link
Collaborator Author

Would like to merge, @redeboer what do you think?

@mmikhasenko mmikhasenko mentioned this pull request Jun 4, 2024
Closed
@mmikhasenko
Copy link
Collaborator Author

step by step: not all changes in one PR. This one is good to go, it tests are passing.

@mmikhasenko mmikhasenko merged commit eaf884c into main Jun 4, 2024
3 checks passed
@mmikhasenko mmikhasenko deleted the julia-generic-function branch June 4, 2024 16:57
@mmikhasenko mmikhasenko mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer Awaiting requested review from redeboer

Assignees

@mmikhasenko mmikhasenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmikhasenko