-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper #231
JOSS paper #231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 2134 2134
Branches 608 608
=========================================
Hits 2134 2134 ☔ View full report in Codecov by Sentry. |
@aelanman We'd like your comments on this, you're listed as an author :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the co-author credit!
4ae7147
to
7dbda81
Compare
eed8631
to
b4c8cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Any idea why checks are failing...?
Astropy 6.1 dropped a couple days ago and some new warnings are being generated. I fixed a couple of things in our tests (no non-test code needed to be modified), but most of the warnings are coming from lunarsky, tracked in an issue here: aelanman/lunarsky#27. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a lot of failures, alas.
Oh, yes. There's another transient issue I haven't run down where sometimes on mac builds in the install step setuptools_scm can't find git. Which makes no sense because the repo was cloned with git. This is occasionally seen in other repos too. For now I'll just re-run but long term we need to figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning tests are failing still, not just mac builds.
Right, the warning test failures are due to the new astropy warnings in lunarsky. They won't go away on a re-run but I'm hesitant to pin astropy because of warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks like the failing tests are blocking merging. Do we want to override them?
I re-ran until only the warnings tests were failing, then merged. |
Description
Preparation to submit to JOSS. The compiled paper draft can be seen as an artifact on the paper_draft workflow under Actions.
Motivation and Context
Checklists:
Documentation Change Checklist:
Documentation change checklist: