Skip to content

Commit

Permalink
*= PR requests, + CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
radonnachie committed Dec 25, 2024
1 parent 6072930 commit 2601df0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ All notable changes to this project will be documented in this file.
- ATA has been added to the list of known telescopes.

### Fixed
- Bug in the `uvh5._add` method that expected keys which could be
optional for some phase-center catalog-entry types. This was noticed as an issue when
adding two uvh5 objects that were of type "sidereal" which did not have "info_source"
entries in their phase-center catalogs.
- Bug in the `look_in_catalog` utility function that expected keys which could be
optional for some phase-center catalog-entry types. This was noticed as an issue when
adding two uvh5 objects that were of type "sidereal" which did not have "cat_times"
Expand Down
6 changes: 3 additions & 3 deletions src/pyuvdata/uvdata/uvdata.py
Original file line number Diff line number Diff line change
Expand Up @@ -1397,9 +1397,9 @@ def _consolidate_phase_center_catalogs(
# match, so this is functionally the same source
self._update_phase_center_id(match_id, new_id=cat_id)
# look_in_catalog ignores the "info_source" field, so update it to match
info_source = cat_entry.get("info_source")
if info_source is not None:
self.phase_center_catalog[cat_id]["info_source"] = info_source
self.phase_center_catalog[cat_id]["info_source"] = cat_entry.get(
"info_source"
)
if ignore_name:
# Make the names match if names were ignored in matching
self.phase_center_catalog[cat_id]["cat_name"] = cat_entry["cat_name"]
Expand Down

0 comments on commit 2601df0

Please sign in to comment.