-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add optional near-field corrections to the phasing function #1482
base: main
Are you sure you want to change the base?
Conversation
f89c9cc
to
87f6fb3
Compare
Rather than adding new phase_center_dict keys, let's use a new cat type for near-field phased objects, maybe `"near_field"? Then encourage and support passing a Quantity for distance, but if a scalar is passed interpret it as in meters for near field and parsecs for ephem cat types. Update the docs to be very clear about this. |
87f6fb3
to
ba8783f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: ba8783f | Previous: bca6cf0 | Ratio |
---|---|---|---|
tests/utils/test_bls.py::test_ants_to_bls[min=4259840-len=10] |
215140.27267544658 iter/sec (stddev: 0.000005969824238735253 ) |
434661.1807555354 iter/sec (stddev: 0.0000013012435924847232 ) |
2.02 |
This comment was automatically generated by workflow using github-action-benchmark.
…o be passed as an astropy.units.Quantity object.
…. This will first apply sidereal far-field phasing, then apply near-field corrections.
…ally unprojects the near field corrections.
ba8783f
to
8819458
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 99.93% 99.56% -0.37%
==========================================
Files 63 63
Lines 21849 21939 +90
==========================================
+ Hits 21834 21844 +10
- Misses 15 95 +80 ☔ View full report in Codecov by Sentry. |
Description
Included code to perform near-field corrections through keyword arguments passed to the phase() function.
I added two new keys to the
phase_dict
dictionary (cat_dist_units
andcat_near_field
), allowing the user to specify the units associated with thecat_dist
key, and whether or not to apply near-field corrections (boolean value). As a result, a lot of tests are breaking because these extra keys didn't exist when they were written. I'm having trouble tracking down every instance ofphase_dict
to patch this.It also still isn't clear whether or not an
unproject_near_field()
function is necessary, so I have left in some commented-out lines of code while I work on figuring this out (to be removed or uncommented when this is resolved).Motivation and Context
This feature allows users to specify the RA, DEC, and distance to a near-field source, and "focus" on that source (it will then appear in focus in an image, for example). This is done in practice by calculating the geometric near-field
w
values for each visibility, updating those in theuvw_array
, computing the resulting phase differences, and updating the phase directly for each visibility. This feature is turned off by default (i.e. the default behavior for thephase()
function is just to perform the traditional far-field phasing).Types of changes
Checklist:
New feature checklist: