-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI-DotNet 8.3.0 #369
OpenAI-DotNet 8.3.0 #369
Conversation
- Updated library to .net 8 - Refactored TypeExtensions and JsonSchema generation - Improved JsonSchema generation for enums and dictionaries - Ensured JsonSchema properly handles nullable types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gave me a lot of breaking changes. I won't have time to address them until next week.
From What exactly was breaking for you? |
I was on 7.7.7 😔 |
clear Function.Arguments after invoking to prevent re-serialization clear Function.Arruments before submitting tool list to API
Copilot Summary:
This pull request includes several updates across multiple files, focusing on upgrading the target framework, improving JSON schema generation, and enhancing code quality. The most important changes include upgrading the project files to use .NET 8.0, adding a new test for JSON schema generation, and refactoring the JSON schema generation logic in
TypeExtensions
.Framework Upgrade:
net6.0
tonet8.0
inOpenAI-DotNet-Proxy.csproj
,OpenAI-DotNet-Tests-Proxy.csproj
, andOpenAI-DotNet-Tests.csproj
.Testing Enhancements:
Test_02_02_GenerateJsonSchema_PrimitiveTypes
method to test JSON schema generation for various primitive types.JSON Schema Generation Refactoring:
TypeExtensions
to improve JSON schema generation, including adding helper methods likeTryGetSimpleTypeSchema
,TryGetDictionaryValueType
, andTryGetCollectionElementType
.Code Quality and Consistency:
toolList.Any()
withtoolList is { Count: > 0 }
and added logic to clear lingering function arguments inChatRequest
.JsonConverter
attributes to useExtensions.JsonStringEnumConverter
in multiple files for consistency.Other Changes:
.gitattributes
file to simplify repository configuration.