Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed gitignore handling #347

Merged
merged 2 commits into from
Feb 28, 2024
Merged

changed gitignore handling #347

merged 2 commits into from
Feb 28, 2024

Conversation

mzuenni
Copy link
Collaborator

@mzuenni mzuenni commented Feb 27, 2024

@mpsijm
Copy link
Collaborator

mpsijm commented Feb 27, 2024

Thanks for simplifying the implementation, but I think I still don't like having (redundant) .gitignore files in the root of my problem directory 😅 I think we need more opinions here 😛

@mzuenni
Copy link
Collaborator Author

mzuenni commented Feb 27, 2024

it should be easy to change now ^^ (as long as the gitignore stays in the problem folder). I just hope that i found all places that needed a change

@mpsijm
Copy link
Collaborator

mpsijm commented Feb 27, 2024

it should be easy to change now ^^ (as long as the gitignore stays in the problem folder).

But it's not easy to change when I don't have a .gitignore file in my problem folders, and BAPCtools keeps regenerating it 😅

@mzuenni
Copy link
Collaborator Author

mzuenni commented Feb 27, 2024

I meant it should be easy to change the code if we decide for the self ignoring gitignore in /data.

bin/generate.py Show resolved Hide resolved
skel/problem/.gitignore Outdated Show resolved Hide resolved
@RagnarGrootKoerkamp
Copy link
Owner

RagnarGrootKoerkamp commented Feb 27, 2024

I also like putting this in the problem .gitignore. Indeed it's a bit redundant but I agree it's more a problem than a contest setting, and anyway these files are automatically generated so there is little overhead.
Also, adding problem/.gitignore is a clear indication to the user that we are ignoring the generated cases, since this file will be part of git status and then be committed. A self-ignoring problem/data/.gitignore is much more hidden to the user, and they may be surprised why cases are not being comitted.

So this settles A1 and B2 from #305. That only leaves the cleanup of unknown-file handling (C).

@mzuenni mzuenni merged commit 4ae7007 into RagnarGrootKoerkamp:master Feb 28, 2024
2 checks passed
@mzuenni mzuenni deleted the new-gitignore branch March 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants