Enable visualizing surface normals with "pointy" triangles (via a new DebugDraw primitive) #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it way easier to see when things have gone horribly wrong. It only generates a single triangle (pointed like an arrow of sorts) to minimize the amount of vertices generated; it would be possible to make an actual arrow, but honestly it isn't needed.
This is mostly so that visual testing becomes easier (can just use the existing cube3d demo scene).
A flatly shaded unit cube is probably the simplest "interesting" shape to test the generated normals visualization with.
They are currently placeholders, but while implementing smooth shading for terrain surfaces this tool came in handy - might want to re-enable it later if some changes have to be made here.
This is the default WebGPU limit, so it should be safe to use. The existing one is too small to render large maps with normal visualization enabled (such as schg_dun01 or nif_fild01) - there's just too many vertices since each vertex normal necessitates three more for the visualization itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #334.