Implement directional lighting with screen blending for RSW scenes #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
133-directional-rsw-lighting
branch
from
2371030
to
5fd11d9
Compare
The blending is somewhat experimental; I half-suspect it doesn't work correctly for certain scenes but this needs to be investigated further (later).
That's a copy/paste error if ever I've seen one... The tests didn't catch it because they used identical values for all light components.
rdw-software
force-pushed
the
133-directional-rsw-lighting
branch
from
5fd11d9
to
21473bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't look quite right without the smooth terrain shading, but that still needs some cleanup - coming soon.
Resolves #133.